From 1950c29ac3d5ea8710b0cd25ecd89d9c66efd142 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Moritz=20H=C3=B6lting?= <87192362+moritz-hoelting@users.noreply.github.com> Date: Thu, 27 Feb 2025 16:38:23 +0100 Subject: [PATCH] only generate uninstall function if it contains commands --- src/datapack/mod.rs | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/src/datapack/mod.rs b/src/datapack/mod.rs index 06e7f0d..eccfced 100644 --- a/src/datapack/mod.rs +++ b/src/datapack/mod.rs @@ -195,13 +195,15 @@ impl Datapack { } if let Some(uninstall_commands) = uninstall_commands { - let main_namespace = modified_namespaces - .entry(&self.main_namespace_name) - .or_insert_with(|| Cow::Owned(Namespace::new(&self.main_namespace_name))); - let uninstall_function = main_namespace.to_mut().function_mut("uninstall"); - uninstall_function - .get_commands_mut() - .extend(uninstall_commands); + if !uninstall_commands.is_empty() { + let main_namespace = modified_namespaces + .entry(&self.main_namespace_name) + .or_insert_with(|| Cow::Owned(Namespace::new(&self.main_namespace_name))); + let uninstall_function = main_namespace.to_mut().function_mut("uninstall"); + uninstall_function + .get_commands_mut() + .extend(uninstall_commands); + } } // Compile namespaces